Skip to content

make: Better quick-fix #44325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

make: Better quick-fix #44325

merged 2 commits into from
Sep 17, 2025

Conversation

@YakDriver
Copy link
Member

@YakDriver YakDriver commented Sep 17, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds

  • Improvement of make quick-fix: adds website terrafmt fixing
  • New target website-terrafmt-fix that does cdktf-friendly website terrafmt fixing
  • Better handling of K, PKG, SVC_DIR, interchangability (backwards compatible)
  • Updated docs on intent of vars

Relations

Relates #43669 (pulled out of)

References

Output from Acceptance Testing

% make quick-fix K=ec2         
make: Quick fixes...
make: Fixing source code with gofmt...
gofmt -s -w ./internal/service/ec2 ./names ./.ci/providerlint/helper ./.ci/providerlint/main.go ./.ci/providerlint/passes
make: Fixing Acceptance Test Linting / terrafmt...
make: Fixing source code imports with goimports...
make: Fixing checks for modern Go code...
make: Validating Semgrep configuration files...
/opt/homebrew/Cellar/semgrep/1.136.0/libexec/lib/python3.13/site-packages/opentelemetry/instrumentation/dependencies.py:4: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  from pkg_resources import (
Configuration is valid - found 0 configuration error(s), and 1587 rule(s).

✨ If Semgrep missed a finding, please send us feedback to let us know!
   See https://semgrep.dev/docs/reporting-false-negatives/
make: Running Semgrep checks locally (must have semgrep installed)...
make: Applying fixes with --autofix
make: WARNING: This will not fix rules that don't have autofixes

┌──── ○○○ ────┐
│ Semgrep CLI │
└─────────────┘

/opt/homebrew/Cellar/semgrep/1.136.0/libexec/lib/python3.13/site-packages/opentelemetry/instrumentation/dependencies.py:4: UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.
  from pkg_resources import (
                                                                                                                        
Scanning 667 files (only git-tracked) with 1598 Code rules:
            
  CODE RULES
  Scanning 553 files with 422 go rules.
                    
  SUPPLY CHAIN RULES
                                                                       
  💎 Sign in with `semgrep login` and run               
     `semgrep ci` to find dependency vulnerabilities and
     advanced cross-file findings.                                     
                                                                       
          
  PROGRESS
   
  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:07                                                                                                                        
no files modified.
                
                
┌──────────────┐
│ Scan Summary │
└──────────────┘
✅ Scan completed successfully.
 • Findings: 0 (0 blocking)
 • Rules run: 422
 • Targets scanned: 553
 • Parsed lines: ~99.9%
 • Scan skipped: 
   ◦ Not matching --include patterns: 21575
   ◦ Files matching .semgrepignore patterns: 54
 • Scan was limited to files tracked by git
 • For a detailed list of skipped files and lines, run semgrep with the --verbose flag
Ran 422 rules on 553 files: 0 findings.
(need more rules? `semgrep login` for additional free Semgrep Registry rules)


✨ If Semgrep missed a finding, please send us feedback to let us know!
   See https://semgrep.dev/docs/reporting-false-negatives/
make: Fix Website / terrafmt...
make: terrafmt fix website/docs root files...
make: Fixing ./website/docs/d with terrafmt...
make: Fixing ./website/docs/ephemeral-resources with terrafmt...
make: Fixing ./website/docs/functions with terrafmt...
make: Fixing ./website/docs/guides with terrafmt...
make: Fixing ./website/docs/r with terrafmt...

@YakDriver YakDriver requested a review from a team as a code owner September 17, 2025 12:04
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/S Managed by automation to categorize the size of a PR. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 17, 2025
@YakDriver YakDriver added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 17, 2025
@YakDriver YakDriver mentioned this pull request Sep 17, 2025
Merged
7 tasks
jar-b
jar-b approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@YakDriver YakDriver merged commit 4ec7e64 into main Sep 17, 2025
37 checks passed
@YakDriver YakDriver deleted the f-make-file-quick-fix branch September 17, 2025 13:31
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.14.0 milestone Sep 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

This functionality has been released in v6.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

No one assigned

Labels

repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/S Managed by automation to categorize the size of a PR.

Projects

None yet

Milestone

v6.14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@YakDriver @jar-b